D20760: Okular Annotation: add support for line ending style for Straight Line tool

[Rajeesh K Nambiar]

knambiar added a comment.


  In D20760#455290 <https://phabricator.kde.org/D20760#455290>, @tobiasdeiminger wrote:
  
  > Nice patch! Guess unicode symbols are good for a start.
  
  
  Thanks!
  
  > Would it be useful if I tried to provide an SVG as replacement for the unicode symbols in an upcoming version, to resemble the exact line end drawing instructions as we do them in poppler code <https://gitlab.freedesktop.org/poppler/poppler/blob/master/poppler/Annot.cc#L1710>?
  
  Certainly. Meanwhile I read the documentation and see that `QComboBox::setItemIcon` can be used to set the icon for combo box text.
  
  P.S.: I couldn't find the drawing methods in poppler at `Annot.cc:1710`, assuming it is at line 1576, method `AnnotAppearanceBuilder::drawLineEnding`.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20760

To: knambiar, #okular, #vdg
Cc: tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190424/4f8c6617/attachment.html>