D19717: Search function fails to find phrases split over two lines

[Albert Astals Cid]

aacid added a comment.


  In D19717#454567 <https://phabricator.kde.org/D19717#454567>, @joaonetto wrote:
  
  > In my honest opinion we shouldn't support for '\n' search, unless it's something like regex search, but I see you disagree.
  
  
  I'm not saying to support \n that is not a character, i'm speaking of the actual newline character, which already works and breaks with this patch. I think it's not great that we modify what the user choses to search, but on the other hand i see were already running normalization on it so what do i know 🤷
  
  BTW QRegexp is "old", should be using QRegularExpression instead ideally

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D19717

To: joaonetto, #okular
Cc: davidhurka, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190422/46c001a4/attachment.html>