D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

[Ahmed Bilal]

ahmedbilal added a comment.


  In D20351#446498 <https://phabricator.kde.org/D20351#446498>, @sander wrote:
  
  > I like the color part of this patch.
  >
  > As for the line width:  As mentioned, '3' is arbitrary.  You need to find a width that takes current dpi into account.  Ideally, the width should be what later gets written into the pdf file.
  >
  > The fact that the rectangle is currently not completely drawn sounds like a Qt bug.  What is the pen width without your patch?  Even if it has width 0 it should paint a 1-pixel line.  Or is the page downscaled somewhere after rendering?
  
  
  I managed to make it the same size as the resultant rectangle. However, @ngraham and @aacid says that the width (3px) is too much for their eyes. So, I think it should be at max 2 or something like that. By default, the pen width is 0 which is actually 1-pixel wide as you mentioned. I will look into it whether it is downscaled or not. Thanks for such nice and helpful comment.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20351

To: ahmedbilal, #okular, okular-devel, ngraham
Cc: sander, aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190409/1c18d881/attachment.html>