D20351: Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle

[Nathaniel Graham]

ngraham added a comment.


  In D20351#445808 <https://phabricator.kde.org/D20351#445808>, @ahmedbilal wrote:
  
  > In D20351#445682 <https://phabricator.kde.org/D20351#445682>, @ngraham wrote:
  >
  > > In D20351#445664 <https://phabricator.kde.org/D20351#445664>, @aacid wrote:
  > >
  > > > 3 is an arbitrary width, so -1 for this change
  > >
  > >
  > > I'm not a huge fan either, but not because it's arbitrary (everything visual is arbitrary) but rather because this makes it look too thick to my eye.
  >
  >
  > There is issue with the preview rectangle. May be its just me or may be its for everyone. The rectangle has right and bottom sides thicker than the top and the left sides. Sometimes, top and sometime left even disappears. If we make the width >= 2 the top and left side doesn't disappear atleast.
  
  
  Then it seems like the chosen value of `3` is just working around a deeper issue. In such cases, it's universally preferred to investigate and fix that issue rather than work around it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20351

To: ahmedbilal, #okular, okular-devel, ngraham
Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190408/b030439c/attachment.html>