D18179: PDF: Implement scaling options for non-rasterized printing

Albert Astals Cid noreply at phabricator.kde.org
Wed Apr 3 21:24:16 BST 2019


aacid added inline comments.

INLINE COMMENTS

> fileprinter.h:58
> +     *
> +     * @since 1.7
> +     */

the since will need to be 1.8 (and all the other 1.7 you added)

> fileprinter.h:61
> +    enum ScaleMode {
> +        None = 0,
> +        FitToPrintArea = 1

Make this no Scale or something similar since otherwise

FilePrinter::None seems like you're saying "none printer"

REPOSITORY
  R223 Okular

BRANCH
  michaelweghorn/UPDATE_D18179

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190403/bff76379/attachment.html>


More information about the Okular-devel mailing list