D15580: New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  I can't get this to compile on git master:
  
    In file included from /home/dev/repos/okular/ui/pageviewannotator.cpp:1245:0:
    /home/dev/repos/okular/moc_pageviewannotator.cpp: In static member function ‘static void PageViewAnnotator::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’:
    /home/dev/repos/okular/moc_pageviewannotator.cpp:83:21: error: ‘class PageViewAnnotator’ has no member named ‘slotToolDoubleClicked’; did you mean ‘slotToolSelected’?
             case 2: _t->slotToolDoubleClicked((*reinterpret_cast< int(*)>(_a[1]))); break;
                         ^~~~~~~~~~~~~~~~~~~~~
                         slotToolSelected
  
  Are there some dependencies I'm missing? Or did it break when the Typewriter annotation patch went in?
  
  Also, long press is never particularly intuitive; it's generally preferred to use a Split button instead. Spectacle uses one of these to good effect: F6296158: Split button.png <https://phabricator.kde.org/F6296158>

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: ngraham, tobiasdeiminger, okular-devel, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180930/debed7bb/attachment.html>