[okular] [Bug 353401] Feature requst: "typewriter" annotation tool

[Tobias Deiminger]

https://bugs.kde.org/show_bug.cgi?id=353401

Tobias Deiminger <haxtibal at posteo.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/oku
                   |                            |lar/6dd7cf662d2335c035e7238
                   |                            |9978f32ee43dc94f2
         Resolution|---                         |FIXED
             Status|REPORTED                    |RESOLVED

--- Comment #29 from Tobias Deiminger <haxtibal at posteo.de> ---
Git commit 6dd7cf662d2335c035e72389978f32ee43dc94f2 by Tobias Deiminger, on
behalf of Dileep Sankhla.
Committed on 25/09/2018 at 20:47.
Pushed by tobiasdeiminger into branch 'master'.

Add typewriter annotation tool

Summary:
Typewriter is originally specified by the PDF reference as special FreeText
annotation, where Intent=FreeTextTypewriter. It features opaque letters on
transparent background, so that users can fill non interactive forms. Herewith
typewriter is implemented natively for PDF, and there's also an Okular specific
implementation for other document types. The added tool reuses the inline note
UI.

This work was done during GSoC 2018. See
https://community.kde.org/GSoC/2018/StatusReports/DileepSankhla for details.

Test Plan:
- okularpartrc is generated (if not yet existing) with typewriter as 10th tool
- typewriter tool is also available in Annotation Tools -> Add, Typ
"Typewriter"
- selecting the tool and left click into document opens inline note input
dialog
- finishing creates an annotation similar to inline note, but with transparent
background
- saving into PDF results in /Subtype FreeText /IT /FreeTextTypeWriter
- saving typewriter into archive stores color with alpha channel = 0x00
- opening annotated archive works, if archive was created with old Okular, and
opened in patched Okular
- opening annotated archive works, if archive was created with patched Okular,
and opened in old Okular

Reviewers: sander

Reviewed By: sander

Subscribers: ngraham, sander, okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D15204

M  +34   -0    conf/editannottooldialog.cpp
M  +2    -1    conf/editannottooldialog.h
M  +6    -1    ui/annotationpropertiesdialog.cpp
M  +122  -74   ui/annotationwidgets.cpp
M  +28   -8    ui/annotationwidgets.h
M  +9    -1    ui/annotwindow.cpp
M  +2    -0    ui/data/CMakeLists.txt
A  +-    --    ui/data/sources/tool-typewriter-okular-colorizable.svgz
A  +-    --    ui/data/tool-typewriter-okular-colorizable.png
A  +-    --    ui/data/tool-typewriter-okular-colorizable at 2x.png
M  +13   -8    ui/data/tools.xml
M  +6    -1    ui/guiutils.cpp
M  +1    -1    ui/pagepainter.cpp
M  +65   -44   ui/pageviewannotator.cpp

https://commits.kde.org/okular/6dd7cf662d2335c035e72389978f32ee43dc94f2

-- 
You are receiving this mail because:
You are the assignee for the bug.