D15574: Avoid undefined behavior due to dangling file descriptor

Anthony Fieroni noreply at phabricator.kde.org
Mon Sep 17 13:39:44 BST 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> presentationwidget.cpp:1763
>  #ifdef Q_OS_LINUX
> -    if (m_sleepInhibitCookie) {
> -        ::close(m_sleepInhibitCookie);
> -        m_sleepInhibitCookie = 0;
> +    if (m_sleepInhibitFd) {
> +        ::close(m_sleepInhibitFd);

It should be != -1

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15574

To: tobiasdeiminger
Cc: anthonyfieroni, okular-devel, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180917/86af3ab3/attachment.html>


More information about the Okular-devel mailing list