D15205: Support setting font color for typewriter annotation

Tobias Deiminger noreply at phabricator.kde.org
Sat Sep 1 13:48:58 BST 2018


tobiasdeiminger created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
tobiasdeiminger requested review of this revision.

REVISION SUMMARY
  2nd part of Dileep Sankhlas GSoC 18 project.
  The original work is in D13203 <https://phabricator.kde.org/D13203>, Diff ID range 37290 to 38049.
  
  Depends on D15204 <https://phabricator.kde.org/D15204>. Also depends on new poppler API, see
  https://gitlab.freedesktop.org/poppler/poppler/merge_requests/10

TEST PLAN
  - properties dialog of typewriter annotation has "Font Color" picker
  - saving to PDF results in <r> <g> <b> rg operation in /DA
  - saving to archive results in fontColor="rrggbb" attribute in metadata.xml

REPOSITORY
  R223 Okular

BRANCH
  typewriter_td_fontcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15205

AFFECTED FILES
  conf/editannottooldialog.cpp
  core/annotations.cpp
  core/annotations.h
  generators/poppler/CMakeLists.txt
  generators/poppler/annots.cpp
  generators/poppler/config-okular-poppler.h.cmake
  ui/annotationwidgets.cpp
  ui/pagepainter.cpp
  ui/pageviewannotator.cpp

To: tobiasdeiminger
Cc: okular-devel, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180901/0113a9b2/attachment.html>


More information about the Okular-devel mailing list