D16285: Remember printing option and print range in the print dialog

[Albert Astals Cid]

aacid added a comment.


  Ok, understood.
  
  Personally i do not like this feature, the fact that i printed page 2 out of 400 of a document four months ago really means nothing regarding what i want to print now, in fact, most probably page 2 is exactly what i do not want to print.
  Also it is not a behaviour the rest of KDE Applications has so it creates confusion amonsgt users why Okular seems to remember some settings but the rest of applications that seemingly have "the same printing dialog" behave different.
  
  Besides that, i think the function names/comments could be improved
  
    /**
     * Sets the printing range of the current document
     */
    void setPrintRange(int from, int to);
  
  doesn't really have to do anything with setting the printing rahge, all it does is save some value in an xml file.
  
  So probably something like
  
    /**
     * Sets the last page range used when printing the current document
     */
    void setLastPrintRange(int from, int to);
  
  makes more sense.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16285

To: ahmadosama, #okular
Cc: aacid, yurchor, broulik, ngraham, okular-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20181022/a3881d3e/attachment.html>