D15691: Add unarchiver support for cbr files

[Albert Astals Cid]

aacid added a comment.


  I'm not thrilled about all these dynamic_cast< UnarFlavour * > in the ifs.
  
  Do you think you could fine a way to extend UnrarFlavour with a few virtuals so instead of ifs you would call functions in the helper that would do the work?
  
  i.e. something like processListing?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15691

To: fb
Cc: aacid, okular-devel, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20181008/bf61365d/attachment-0001.html>