D15205: Support setting font color for typewriter annotation

Oliver Sander noreply at phabricator.kde.org
Tue Oct 2 20:14:18 BST 2018


sander added inline comments.

INLINE COMMENTS

> annotationwidgets.cpp:223
>      }
> -
>      QWidget * styleWidget = createStyleWidget();

Why this whitespace change?

> annotationwidgets.cpp:315
> -    addTextAlignComboBox(widget, innerlay);
> -    addWidthSpinBox(widget, innerlay);
>  }

I think these whitespace changes should be in a separate patch (if they are desired at all).

> annotationwidgets.cpp:321
>      layout->addLayout( innerlay );
> -    addFontRequester(widget, innerlay);
>  }

I think this whitespace change should be in a separate patch (if it is desired at all).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15205

To: tobiasdeiminger
Cc: kde-doc-english, sander, okular-devel, ngraham, skadinna, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20181002/1636369f/attachment.html>


More information about the Okular-devel mailing list