D16941: Fix inconsistent viewport positioning in PageView

[Tobias Deiminger]

tobiasdeiminger added a comment.


  @aacid When is the last chance to get something into 18.12 release? Already passed?
  
  I'm asking because we have two interfering issues here, where the first should be reasonably fixed with this diff (test still missing), but the second may take longer. Maybe we can split it, and get the first in?
  
  1. inconsistent calculation of viewport placement (fixed now)
  2. viewport displaced a bit again, when `finished` signals arrive from pixmap generation thread asynchronously, causing `notifyPageChanged( page, DocumentObserver::BoundingBox )` and `PageView::slotRelayoutPages`
  
  If there's a chance to get 1 in, I'll focus on it (i.e., implement a test).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16941

To: tobiasdeiminger, #okular
Cc: sander, aacid, okular-devel, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20181120/e36e16de/attachment-0001.html>