D11723: Add FormFieldSignature to Okular namespace

Albert Astals Cid noreply at phabricator.kde.org
Thu May 31 13:21:19 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> formfields.cpp:420
> +    auto sigInfo = m_field->validate( Poppler::FormFieldSignature::ValidateVerifyCertificate );
> +    return static_cast<Okular::SignatureInfo*>( new PopplerSignatureInfo( sigInfo ) );
> +}

Why a static_cast here?

> pdfsignatureinfo.cpp:43
> +{
> +}
> +

You need to delete d_ptr?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11723

To: chinmoyr, aacid
Cc: ngraham, okular-devel, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180531/fce3334d/attachment.html>


More information about the Okular-devel mailing list