D13114: Add DocumentRevision to Okular

[Albert Astals Cid]

aacid added a comment.


  In D13114#269422 <https://phabricator.kde.org/D13114#269422>, @chinmoyr wrote:
  
  > In D13114#269280 <https://phabricator.kde.org/D13114#269280>, @aacid wrote:
  >
  > > Can you explain what's the use case for this?
  >
  >
  > Adobe reader allows user to view different signed revisions of a PDF. This patch intends to implement
  >  that feature.
  >
  > > I thought we had agreed  that using qvariantmaps for passing structures was a bad idea. 
  > >  If i have to implement this for my AwesomeGenerator, how do i know what comes in revData?
  >
  > My bad, I thought you were talking about returning a QVariantMap. I will correct it in next update.
  >
  > > Also the API is weird, you have
  > > 
  > >   QString generateDocumentRevision( int revNum );
  > > 
  > > but which revNums are you going to use.
  >
  > The revision number starts from 1 and goes till the total number of signature form fields. The idea here is to 
  >  include the total number of signature fields in generator's metadata
  
  
  another thing you want to pass through a qvariant? if you need a getter, add a getter :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13114

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180531/151a1fa6/attachment.html>