D13203: Add Typewriter annotation tool in Okular

[Tobias Deiminger]

tobiasdeiminger added a comment.


  In D13203#271231 <https://phabricator.kde.org/D13203#271231>, @dileepsankhla wrote:
  
  > I mean isn't it enough to change the line to `acolor.setAlpha( a->style().opacity() * a->style().color().alpha() )` as you suggested? Why do we need to change the Poppler's one?
  
  
  I didn't mean to change anything in Poppler. I meant it's the way it works in Poppler right now. I assume if both 'rg' operator and 'ca' entry are applied, alpha gets multiplied. Probably also depending on blend mode. I don't know how this works exactly, it's a longer read through AnnotFreeText::generateFreeTextAppearance and the spec (e.g. 11.6.3 Specifying Blending Colour and Blend Mode). Maybe you can figure it out on your own?
  
  > Secondly, in my opinion, we should change L 628 to `unsigned int opacity = (unsigned int)( a->style().color().alpha() * a->style().opacity() )` and here the variable `opacity` will determine the background color of FreeText.
  
  You're right, that's better.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13203

To: dileepsankhla
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180531/5398d98f/attachment.html>