D13114: Add DocumentRevision to Okular

[Albert Astals Cid]

aacid added a comment.


  Can you explain what's the use case for this?
  
  I thought we had agreed  that using qvariantmaps for passing structures was a bad idea. 
  If i have to implement this for my AwesomeGenerator, how do i know what comes in revData?
  
  Also the API is weird, you have
  
    QString generateDocumentRevision( int revNum );
  
  but which revNums are you going to use.
  
  I would really appreciate if you could talk to me on IRC because I'm lost at what you're trying to accomplish.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13114

To: chinmoyr, aacid
Cc: okular-devel, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180527/e2d593fe/attachment.html>