D7662: Draw a dark rectangle around highlighted search results

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  That is a fix, not the ideal fix, now that i've had time to look at the problem, the problem is.
  
  Basically that we're writting in the "buffered" area of the painter, which means we reuse it from paint to paint unless something big has happened, since we reuse it from paint to paint and if we're intersecting with limits it means that when a highlight it is cut by border "of the screen" we'll only paint part of the highlight, which means that when we scroll to show all the higlight we only paint the "new" area of the highlight, reusing the old one, that was fine before since it's just a colored rectangle, but now that it has borders it means that the old border that was "in the middle" of the highlight is kept.
  
  Ideally one would move the border painting to the non buffered area (i.e. the area that is not reused from paint to paint), but that'd be quite a lot of job so what i've made is partially use the suggestion from @simgunz but only applied to the hightlight rects.
  
  I'll commit in a minute

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7662

To: sander, #okular, aacid
Cc: okular-devel, simgunz, cfeck, aacid, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180518/c38e5a6f/attachment.html>