D11594: Add support for hide action

Andre Heinecke noreply at phabricator.kde.org
Fri Mar 23 07:27:32 UTC 2018


aheinecke added inline comments.

INLINE COMMENTS

> Link.h:468
> +
> +  // According to spec the target can be either:
> +  // a) A text string containing the fully qualified name of the target

I've looked at the spec but did not understand what should be happening with "An indirect reference to an annotation dictionary" and as a result I did not understand what "An array of such dictionaries" would look like. My guess is that it would be similar to the Annotation Ref in a Movie.

But as I could not come up with a test for this using Adobe DC and did not have at an example I did not add API for this and only added API for what I fully understood and could test.

My reasoning is that it is better not to have API, so that it can later be added, instead of wrong API that has to be carried around for compatibility.

REVISION DETAIL
  https://phabricator.kde.org/D11594

To: aheinecke, #okular
Cc: michaelweghorn, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180323/9732b278/attachment-0001.html>


More information about the Okular-devel mailing list