D10865: [1/5] Access readOnly state of FormWidgets dynamically

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> aheinecke wrote in pageview.cpp:1002
> No, setCanBeFilled accesses isReadOnly. This crashes if the formWidgets are not yet updated with the new fields.
> 
> I also think that it is better to only modify the field here and not earlier to avoid working with formWidgets that have dangling pointers to deleted fields in them.

Ok, so now that setCanBeFilled doesn't access the form, do we really need this extra if?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10865

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180314/bae9b6e6/attachment.html>