D10974: PDF: Make the "fit-to-page" print option configurable

[Michael Weghorn]

michaelweghorn added a comment.


  In D10974#217646 <https://phabricator.kde.org/D10974#217646>, @aacid wrote:
  
  > so you worded point 4 and point 6 (second point 5) differently "the document is not scaled at all now." vs "The document is scaled to the full page size", i would not expect Force Rasterize to cause different behaviour.
  >
  > Is it just that you wrote it differently or does Force Rasterize actually change the behaviour of "Fit to printable area"?
  
  
  As of now, it actually does behave differently. The "Force rasterization" option does not use `FilePrinter`, but Qt's "normal way of printing" (which is why e.g. n-up-printing also behaves a little different there). For the "Force rasterization" case, the only thing that changes is whether the printer margin is taken into account or not. If you print an A4 document to A3 paper and unselecting the "Fit to printable area", currently
  
  - `FilePrinter` would not scale the document at all, thus leaving a lot of blank space on the printout.
  - The "force rasterization" option would scale the document to A3, ignoring the printer hardware margins.
  
  Thinking about this again, I think `FilePrinter` should react to the value returned by `QPrinter::fullPage()` in the same way as the "force rasterization" option, since this is what the option actually means [1]:
  
  > `void QPrinter::setFullPage(bool fp)`
  >  If fp is true, enables support for painting over the entire page; otherwise restricts painting to the printable area reported by the device.
  
  Rather than not setting the "fit-to-page" option, the margins should not be set in FilePrinter in this case.
  
  When document page size and the printer's page size is the same, this does not make any difference as compared to not setting the `fit-to-page` option. But it does make a diference when the two page sizes do not match (as described above).
  
  What do you think?
  
  1: http://doc.qt.io/qt-5/qprinter.html#fullPage

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: aacid, ngraham, michaelweghorn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180304/0f8c5c31/attachment-0001.html>