D13203: Add Typewriter annotation tool in Okular

[Dileep Sankhla]

dileepsankhla marked 4 inline comments as done.
dileepsankhla added inline comments.

INLINE COMMENTS

> tobiasdeiminger wrote in editannottooldialog.cpp:128
> > So if we adopt the new color format in the default tools in tools.xml, do we need to alter all the color entries? Or is it okay to have two color formats?
> 
> I'm not sure if I understand this question. Of course not all color entries that appear somewhere in okular source code 😃 We shall just be consistent with
> 
>   const QString color = m_stubann->style().color().name(QColor::HexArgb);
> 
> So adapt everything to #AARRGGBB that will affect Okular::Annotation::style()->color(). Afaikt this are the color=... attributes of <annotation> elements in tools.xml. But not the color=... attributes of <engine> elements, because they don't affect Okular::Annotation::style()->color(). Are there other places?

> Are there other places?

No, there are not. I'm updating the revision with tools.xml having <annotation> elements color attributes incorporating #AARRGGBB color format.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13203

To: dileepsankhla, tobiasdeiminger
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180620/7d06362b/attachment-0001.html>