D13203: Add Typewriter annotation tool in Okular

[Dileep Sankhla]

dileepsankhla added inline comments.

INLINE COMMENTS

> tobiasdeiminger wrote in parttest.cpp:1582
> The QInputDialog is pure Qt functionality, just closing it is not that interesting in a typewriter test case. The more interesting thing is to verify if annotation is created correctly after closing.

First of all, in CloseDialogHelper, `m_clicked` is always false as `m_part->widget()->findChild<QDialog*>();` returns NULL for the QInputDialog being the activeModalWidget. So I didn't use it.

Secondly, I agree that the low tests should be independent but I'm using `QTimer` technique in `testTypewriterAnnotTool` to grab the pointer to the active QInputDialog widget for which I need to connect the SIGNAL timeout() to the SLOT testDialogClosed which eventually becomes another test method. So I can't do it in only a single method instead need two different methods in which one of them becomes the slot of QTimer implementation. In this case. do you think I should do the same in the dedicated class like PartTestAnnotation?

Thirdly, to verify if the annotation is created correctly, what parameter(s) should I check?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13203

To: dileepsankhla, tobiasdeiminger
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180617/6a666e4c/attachment.html>