D13203: Add Typewriter annotation tool in Okular

[Tobias Deiminger]

tobiasdeiminger added a comment.


  Typewriter annotations created with the initial typewriter tool have a border of width=1 (Okular started without existing okularpartrc). But we always want border width = 0 for typewriter, is it? It could even be hardcoded into drawing code.
  
  This is because you set width = 0 only for EditAnnotToolDialog::m_stubann. But the initial tool entry created out of tools.xml does not use this stub annotation to determine properties. Only further typewriter tools created with the EditAnnotTool config dialog use the stub annotation. So my okularpartrc looks like this:
  
    [Reviews]                                                                                                                       
    AnnotationTools=[...]<tool type="typewriter" id="10"><engine type="PickPoint" color="#000000" block="true"><annotation type="Typewriter" color="#00ffffff"/></engine></tool>,<tool type="typewriter" id="11" name="My own typewriter"><engine type="PickPoint" color="#000000" block="true"><annotation type="Typewriter" color="#00ffffff" width="0"/></engine></tool>
  
  As you see, only the second typewriter has width=0. The first uses default width (=1).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13203

To: dileepsankhla
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180601/7e977c83/attachment.html>