D7949: Allow to print pdf doc directly into a QPrinter

Michael Weghorn noreply at phabricator.kde.org
Fri Jul 20 15:19:35 BST 2018


michaelweghorn added inline comments.

INLINE COMMENTS

> sander wrote in generator_pdf.cpp:1349
> The idea was the following: New conditional are introduced that surround existing code.  For nice identation all of that would have to be reformated, which makes for a patch full of whitespace changes.  I didn't want that, but the new code has been indented directly at the correct indentation.  At least that was the plan...

I don't know what "the right way" to handle this is within the Okular project. I just personally found the code a bit hard to read like this.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7949

To: sander, #okular, rkflx
Cc: okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180720/5dc9ad8a/attachment.html>


More information about the Okular-devel mailing list