D7949: Allow to print pdf doc directly into a QPrinter

[Oliver Sander]

sander added a comment.


  The patch should not influence the behavior of rasterized printing.  The code used QPrinter with the poppler splash backend before, and it should still do that.
  
  Thanks for all the heads up given in this thread, but since Albert was so much opposed to this patch at least originally, I will not push it without explicit consent from him.

INLINE COMMENTS

> michaelweghorn wrote in generator_pdf.cpp:1349
> The indentation here is a little odd in my eyes, since the "if" is indented further than the following lines inside of the "if" block. I think moving the "if" (and "else" below) one indentation level to the "left" and the block one indentation level to the "right" would be the usual way to do it.

The idea was the following: New conditional are introduced that surround existing code.  For nice identation all of that would have to be reformated, which makes for a patch full of whitespace changes.  I didn't want that, but the new code has been indented directly at the correct indentation.  At least that was the plan...

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7949

To: sander, #okular, rkflx
Cc: okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180720/8489359b/attachment.html>