D14102: Add share action to selection context menu

[Albert Astals Cid]

aacid added a comment.


  I personally don't think this makes much sense, but I'm not a heavy Okular user either.
  
  In D14102#293160 <https://phabricator.kde.org/D14102#293160>, @apol wrote:
  
  > I'd say it would make sense to just make it possible to drag and drop this to the quick share plasmoid. Or just put it on the clipboard and paste it there.
  
  
  You can't drag the selection goes away once the menu goes away.

INLINE COMMENTS

> pageview.cpp:2851
> +            connect(d->m_shareMenu, &QMenu::triggered, this, [this, selectionRect, sharedFileName] {
> +                // renders page into a pixmap and saves it
> +                QPixmap copyPix( selectionRect.width(), selectionRect.height() );

Don't duplicate code that is just 3 lines below, reuse!

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180719/0eb7c134/attachment.html>