D13203: Add Typewriter annotation tool in Okular

[Tobias Deiminger]

tobiasdeiminger added inline comments.

INLINE COMMENTS

> annots.cpp:182
>              ppl_txtann->setTextFont( okl_txtann->textFont() );
> +            ppl_txtann->setTextColor( okl_txtann->textColor() );
>              ppl_txtann->setInplaceAlign( okl_txtann->inplaceAlignment() );

Poppler::TextAnnotation::setTextFont is brand new poppler API (actually not yet merged). We still want to support builds with older poppler versions. So setTextFont needs to be surrounded by some

  #ifdef HAVE_POPPLER_0_xy
  #endif

where 0_xy is the poppler release for which we assume the API to be released. Maybe 0_67, to be optimistic.

To detect poppler version at build time, add a check_cxx_source_compiles for Poppler::TextAnnotation::setTextFont and define HAVE_POPPLER_0_67 accordingly in generators/poppler/CMakeLists.txt. Also add a cmakedefine to generators/poppler/CMakeLists.txt. You'll find existing examples for other versions if you look at these files.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13203

To: dileepsankhla, tobiasdeiminger
Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180715/61cc05f2/attachment.html>