[okular] [Bug 384381] Cursor over X to close note should be an arrow

Nate Graham bugzilla_noreply at kde.org
Wed Jan 31 18:06:52 UTC 2018


https://bugs.kde.org/show_bug.cgi?id=384381

Nate Graham <pointedstick at zoho.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/oku
                   |                            |lar/de56b9c9c16544465c54ca2
                   |                            |f90709d64481de903

--- Comment #4 from Nate Graham <pointedstick at zoho.com> ---
Git commit de56b9c9c16544465c54ca2f90709d64481de903 by Nathaniel Graham, on
behalf of Dileep Sankhla.
Committed on 31/01/2018 at 17:58.
Pushed by ngraham into branch 'master'.

Use correct arrow cursor for Annotations' close buttons

Summary:
When hovering the mouse over the X symbol to close a note the cursor remains
the same of the current shape (hand, selection cursor) based on the tool
selected.
This patch morphe the cursor to the standard arrow over the X symbol to close a
note by adding setCursor() call in the CloseButton constructor

Test Plan:
1.  Open okular and select Tools -> Review or press F6 to create a new pop-up
note
2. Hover the mouse cursor over the close button (X) of the pop-up note window
3. You will see the standard arrow instead of the current tool based cursor.

Screenshot below (the tooltip saying "Close this note" was not captured by
Spectacle application)
{F5685539}

Reviewers: #okular, ngraham

Reviewed By: ngraham

Subscribers: ngraham, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D10209

M  +1    -0    ui/annotwindow.cpp

https://commits.kde.org/okular/de56b9c9c16544465c54ca2f90709d64481de903

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list