D9328: Add support for cancellable image rendering and text extraction

[Henrik Fehlauer]

rkflx added a comment.


  In https://phabricator.kde.org/D9328#197788, @aacid wrote:
  
  > In https://phabricator.kde.org/D9328#196555, @rkflx wrote:
  >
  > > >> 5. `ASSERT: "page()" in file okular/core/generator_p.cpp, line 129`
  >
  >
  > Ok, i found how to reproduce too and this should be fixed now.
  
  
  Can confirm, and I just noticed that simply running `make test` would've found this problem too (I kinda assumed you ran this, so did not check again).
  
  However, the autotests still have lots of issues (at least for me). As an example, `./autotests/parttest testReload` results in
  
    Thread 1 "parttest" received signal SIGSEGV, Segmentation fault.
    0x00007ffff74c1930 in Okular::TextPageGenerationThread::abortExtraction (this=0x0)
        at okular/core/generator_p.cpp:113
  
  Could you recheck?
  
  ---
  
  >>>> 6. Text page generation not cancellable
  > 
  > […]
  
  Ok, thanks for the explanation, makes sense. It's not ideal, but good enough for now in my book. Maybe add a note to the commit message?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9328

To: aacid, ervin, rkflx
Cc: rkflx, ervin, michaelweghorn, ngraham, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180130/a1d7af2f/attachment.html>