D9328: Add support for cancellable image rendering and text extraction

[Henrik Fehlauer]

rkflx added a comment.


  Better, but not perfect yet ;)
  
  > There's no autotests in https://phabricator.kde.org/D8379, no?
  
  Seems I mixed it up with https://phabricator.kde.org/D8642, sorry.
  
  > 2. OOM killed when changing sidebar size.
  
  I suspect there are multiple issues triggered by sidebar resizing:
  
  - OOM, which seems to be solved with your latest updates.
  - Unresponsiveness, which has been there before. Observation: This is not restricted to Okular, but extends to X. I cannot switch windows (or even move window focus via focus-follows-mouse), which is odd because normally even with all CPU cores busy (here some are idle, still) that's not a problem. I can move the mouse, but the pointer does not change. Maybe Okular has a blocking mouse cursor change call, or does too many of them? For now, I opened Bug 389411 <https://bugs.kde.org/show_bug.cgi?id=389411> about this.
  - NEW issue since your latest updates:
  
  5. `ASSERT: "page()" in file okular/core/generator_p.cpp, line 129` (Happened two times already, but not everytime.)
  
  I'm not sure about the next one, maybe you could comment whether this is related to the patch and if it is intentional or not:
  
  6. Text page generation not cancellable. This can be observed by comparing the reaction to [F5] being pressed while doing incremental rendering vs. shortly after that. Alternatively, zoom in after rendering finished but thumbnail rendering did not start yet, where now you'd have to wait a while until rerendering triggers again.
  
  I'll finalize testing today or tomorrow.

REPOSITORY
  R223 Okular

BRANCH
  cancellable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9328

To: aacid, ervin
Cc: rkflx, ervin, michaelweghorn, ngraham, #okular, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180125/c551abc1/attachment.html>