D9852: Fix crash due to dangling pointer in MouseAnnotation

[Tobias Deiminger]

tobiasdeiminger added inline comments.

INLINE COMMENTS

> pageviewmouseannotation.cpp:423
>  
> +void MouseAnnotation::notifyAnnotationChanged( int pageNumber )
> +{

MouseAnnotation::notifyAnnotationChanged is called frequently while moving or resizing annotations. During these actions each mouse move event causes a call to DocumentObserver::notifyPageChanged. In consequence we call QLinkedList::contains (has O(n)) frequently, see AnnotationDescription::isContainedInPage. Not too bad, but if there was an event that meant "annotation deleted" instead of "annotation changed", that overhead could be avoided. Is there such an event?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9852

To: tobiasdeiminger, #okular
Cc: michaelweghorn, gassaf, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180113/450d5a45/attachment.html>