[okular] [Bug 388228] Okular crashes when annotating a piece of text

[Tobias Deiminger]

https://bugs.kde.org/show_bug.cgi?id=388228

--- Comment #10 from Tobias Deiminger <haxtibal at posteo.de> ---
> Is this problem still existing? Can you reproduce it?

Yes, it still exists in okular master. And I can reproduce it now, thanks to
the valgrind trace telling what's going on.

> I wonder why it works for me and I can't get valgrind to complain at all :S

You need a very special input sequence:
-load document and enable highlight toolbar (F6)
-create highlight annotation
-move the view port so that the annotation position is right beside the
highlight tool icon
-move the mouse over the annotation, and then horizontally left until you reach
the tool icon; it's important to stay over the highlight annotation as long as
in viewport
-press ctrl-z for undo
-click on highlight tool, move right into the document, create new highlight
annotation
-crash happens on mouse release

I'm preparing a fix for this atm. Basically it will forward
DocumentObserver::notifyPageChanged and reset the pointer reference immediately
if an annotation was deleted for some reason. I'm tempted to do a bit more
cleanup/refactoring, should I keep that separated in another patch? What's the
time frame for submitting them?

-- 
You are receiving this mail because:
You are the assignee for the bug.