[okular] [Bug 388511] "Do you want to allow [presentation mode]?" is inaccurate and misleading.

Nate Graham bugzilla_noreply at kde.org
Sun Jan 7 18:49:46 UTC 2018


https://bugs.kde.org/show_bug.cgi?id=388511

Nate Graham <pointedstick at zoho.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/oku
                   |                            |lar/e44d50558323f319e2ebe88
                   |                            |22c1c4545eaa7e53a
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Nate Graham <pointedstick at zoho.com> ---
Git commit e44d50558323f319e2ebe8822c1c4545eaa7e53a by Nathaniel Graham.
Committed on 07/01/2018 at 18:49.
Pushed by ngraham into branch 'master'.

Improve dialog when PDF wants to open in presentation mode

Summary:

- Describe what's actually going to happen if you answer in the affirmative
- Use expressive button text with standard ok/cancel style icons
- Remove tooltips, since they're not needed when the buttons clearly indicate
what will happen when you press them

Test Plan:
New dialog:
{F5626016}

Both buttons still work to do what they say they'll do.

Reviewers: #okular, aacid, rkflx

Reviewed By: rkflx

Subscribers: rkflx

Tags: #okular

Differential Revision: https://phabricator.kde.org/D9692

M  +5    -5    part.cpp

https://commits.kde.org/okular/e44d50558323f319e2ebe8822c1c4545eaa7e53a

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list