D9692: Improve dialog when PDF wants to open in presentation mode

Henrik Fehlauer noreply at phabricator.kde.org
Sat Jan 6 17:55:08 UTC 2018


rkflx added a comment.


  (Helps saving inline comments before pressing "Submit").

INLINE COMMENTS

> part.cpp:1630
>              const QString caption = i18n( "Presentation Mode" );
> -            const KGuiItem yesItem = KGuiItem( i18n( "Allow" ), QStringLiteral("dialog-ok"), i18n( "Allow the presentation mode" ) );
> -            const KGuiItem noItem = KGuiItem( i18n( "Do Not Allow" ), QStringLiteral("process-stop"), i18n( "Do not allow the presentation mode" ) );
> +            const KGuiItem yesItem = KGuiItem( i18n( "Enter presentation mode" ), QStringLiteral("dialog-ok") );
> +            const KGuiItem noItem = KGuiItem( i18n( "Stay here" ), QStringLiteral("dialog-cancel") );

Title Case for buttons, IIRC?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9692

To: ngraham, #okular, aacid, rkflx
Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180106/8b121a46/attachment-0001.html>


More information about the Okular-devel mailing list