D10865: [1/5] Access readOnly state of FormWidgets dynamically

Andre Heinecke noreply at phabricator.kde.org
Mon Feb 26 14:35:04 UTC 2018


aheinecke added inline comments.

INLINE COMMENTS

> pageview.cpp:1002
>              }
> -            else
> +            else if ( !( setupFlags & Okular::DocumentObserver::UrlChanged ) )
>              {

Without this change the PartTest::testSaveAsUndoStackForms would segfault because the underlying fields are destroyed but setCanBeFilled now accesses them to check for readOnly.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10865

To: aheinecke, #okular
Cc: michaelweghorn, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180226/db7a7854/attachment.html>


More information about the Okular-devel mailing list