D10865: [1/5] Access readOnly state of FormWidgets dynamically
Andre Heinecke
noreply at phabricator.kde.org
Mon Feb 26 14:31:18 UTC 2018
aheinecke created this revision.
aheinecke added a reviewer: Okular.
aheinecke added a project: Okular.
aheinecke requested review of this revision.
REVISION SUMMARY
This is more of a cleanup patch that removes the obsolete m_canBeEnabled
member variable which was a leftover IMO from a time where readOnly fields were
shown as disabled. readOnly fields are invisible, not disabled, and the code no longer assumes that
readOnly does not change over time.
TEST PLAN
Tested manually and with a unittest which is part of the series.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D10865
AFFECTED FILES
ui/formwidgets.cpp
ui/formwidgets.h
ui/pageview.cpp
To: aheinecke, #okular
Cc: michaelweghorn, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180226/ba74129e/attachment-0001.html>
More information about the Okular-devel
mailing list