D10808: Implement the generation of a custom Info.plist for the Mac OS bundle

[Luigi Toscano]

ltoscano added a comment.


  In D10808#213531 <https://phabricator.kde.org/D10808#213531>, @sbragin wrote:
  
  > In D10808#213518 <https://phabricator.kde.org/D10808#213518>, @ltoscano wrote:
  >
  > > I think that this was already discussed, but would it make sense to have a function in extra-cmake-modules which generates the plist file based on some parameters (known from somewhere else or passed explicitly) instead of hand-writing that file?
  >
  >
  > For me it makes sense for properties that are more or less frequently changing, like the version, or the year of the copyright. And CMake itself supports this. Other properties can be hardcoded, in my opinion, unless you are going to start changing the name of the application once per month or something.
  
  
  Not only that: think about a macro like ecm_add_app_icon:
  https://api.kde.org/ecm/module/ECMAddAppIcon.html
  
  It is a noop on platforms different from Windows and macOS, but it was added to most of our programs, even by programmers who don't usually works on those platforms. But people working on them have the feature enabled "for free". So an hypothetical macro ecm_add_plist_do_some_magic would probably gain some traction also by people not involved with macOS, who don't know who to create a plist file, IMHO.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10808

To: sbragin, #okular, rjvbb, aacid
Cc: ltoscano, aacid, rjvbb, #okular, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180225/b87378c6/attachment.html>