D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> document.cpp:1139
> +                                    m_scripter = new Scripter( this );
> +                                m_scripter->setEvent( event.get() );
> +                                // The value maybe changed in javascript so save it first.

This is problematic since it will leave a dangling event pointer for any Action::Script action executed through Document::processAction that doesn't come from this function.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10048

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180219/43b829a1/attachment.html>