D10455: Add RTL support for search, copy & paste in pdf
Albert Astals Cid
noreply at phabricator.kde.org
Sun Feb 18 22:18:15 UTC 2018
aacid added a comment.
In D10455#208549 <https://phabricator.kde.org/D10455#208549>, @fahadalsaidi wrote:
> @aacid any feedback?
I'm still unconvinced the text reversion is happening at the proper level.
Anyway meanwhile please change the test so that uses qtry_compare instead of the qtimer loop (i just fixed that for the other test)
And you have a memory leak in your function as reported by
valgrind --leak-check=full ./autotests/searchtest
please fix.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D10455
To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180218/06f64572/attachment.html>
More information about the Okular-devel
mailing list