D10073: [PATCH 1/4] Add JavaScript Event Object handling

Andre Heinecke noreply at phabricator.kde.org
Thu Feb 15 14:29:23 UTC 2018


aheinecke added inline comments.

INLINE COMMENTS

> aacid wrote in kjs_field.cpp:222
> Or just don't store the page as const pointer?

I passed it as const as I only saw API in document to get a const page reference and recalculateForms also used a const reference.
But yes I see now that document private can easily access a non const page reference thorugh the page vector.

I'll change it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10073

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham, simgunz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180215/1f533d58/attachment.html>


More information about the Okular-devel mailing list