D10504: Bug 288042 - Option to reset forms

[Albert Astals Cid]

aacid added a comment.


  Same as I asked Gilbert in reviewboard.
  
  Do you think you could do an autotest using formSamples.pdf ?

INLINE COMMENTS

> part.cpp:1548
>      {
> +        /* original
>          m_formsMessage->setText( i18n( "This document has forms. Click on the button to interact with them, or use View -> Show Forms." ) );

This is not how you do coding, you don't leave the old code commented around.

> formwidgets.cpp:552
> +    // TODO:
> +    setText("");
> +}

this is wrong, you want QString()

> formwidgets.h:160
>  
> +        //ChangeHere
> +        virtual void clearWidgetContents();

Remove all those markers, we can see the changes.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10504

To: ahmadosama
Cc: aacid, ngraham, #okular, michaelweghorn, simgunz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180214/fd63c4ca/attachment.html>