D10048: [PATCH 2/4] Add refresh widgets if underlying field changes
Andre Heinecke
noreply at phabricator.kde.org
Tue Feb 13 07:46:58 UTC 2018
aheinecke added a comment.
In D10048#205211 <https://phabricator.kde.org/D10048#205211>, @aacid wrote:
> Haven't had time to try myself, but how all this works with undo/redo? Does stuff break or does it work nice?
Ah, no. Undo / Redo does not trigger a new evaluation of calculate actions. But this is not a regression. I'll look at it it in a different patch.
INLINE COMMENTS
> aacid wrote in document.h:1200
> make this 1.4 which will be the actually released version
Ok. But if we make the FormField a QObject we won't need it anymore :-)
Can you answer my question if making FormField a QObject would be ok? That would probably give us the best flexibility for future changes so I would like to do that. :-)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D10048
To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180213/d651cbda/attachment-0001.html>
More information about the Okular-devel
mailing list