D10455: add rtl support to textpage

Fahad Al-Saidi noreply at phabricator.kde.org
Mon Feb 12 09:23:16 UTC 2018


fahadalsaidi created this revision.
fahadalsaidi added a reviewer: Okular.
fahadalsaidi added a project: Okular.
fahadalsaidi requested review of this revision.

REVISION SUMMARY
  Right now all text are sorted  in LTR order in TextPagePrivate::correctTextOrder() regardless from where they come. Since poppler has fixed it since 0.40, I've just ported reorderTex() from poppler to okular and it works. I am not sure what is unicodeTypeL() & unicodeTypeR() mean in poppler context so I just use isRightToLeft() instead.
  
  This patch intended to fix the following bugs:
  BUG: 207748
  BUG: 353299
  BUG: 353300
  BUG: 353301
  BUG: 184399

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

AFFECTED FILES
  core/textpage.cpp

To: fahadalsaidi, #okular
Cc: michaelweghorn, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180212/a498ff0a/attachment.html>


More information about the Okular-devel mailing list