D10415: Fix realDpi function for Mac

[René J.V. Bertin]

rjvbb added a comment.


  >   Sorry, I didn't quite get what you mean. Your patch just makes realDpiX and realDpiY global, but the rest is the same. Am I missing something?
  
  Maybe I'm missing something because I took only quick glances at the code. I was thinking that my patch was simply moving the duplicate Utils::realDPI out of the way, with the result that the application would be using the standard implementation of that function. Apparently I should have looked just a little better :-/
  
  I now tested this patch and confirm that it works on 10.9 with Qt 5.9.3 .
  
  A PDF generated via the print-to-pdf on an A4 sheet renders slightly too large. Maybe just a bit more so than with my own patch but that comparison was hardly done in a scientific manner (holding a piece of paper to my screen that may no longer be exactly A4). Either way, monitor DPI indications are rarely exact so Okular would need a calibration feature if it really wants to display content at a 1:1 scale.
  
  >   It was just testing, nothing more. You never know, what a user decides to do.
  
  Of course, who are we to tell them to stop ruining their eyes :)

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10415

To: sbragin, #okular, rjvbb
Cc: rjvbb, cullmann, aacid, kde-mac, ltoscano, #okular, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180211/b7f06882/attachment.html>