D10415: Fix realDpi function for Mac

[René J.V. Bertin]

rjvbb added a comment.


  >   I agree that your patch is the minimal way to have Okular compiled on Mac.
  
  Not just that, it should result in the same code being used, with just the old code being included as inaccessible "junk DNA". No?
  
  Evidently that's not a proper fix for upstream inclusion.
  
  > (e.g., if the user doesn't set the resolution to 720p instead of native 1080p; of course, not many people would like to do that).
  
  Not on a regular screen, no. Maybe the effects are less "in your face" on a Retina screen, but why would you do it (except when running some old video game or similar)?
  
  >   We discussed the option of submitting patches to Okular into upstream the other day.
  
  OK, sorry I didn't realise that, I had issues from at least 2 people (or rather, user-IDs) recently.
  So I probably don't have to ask not to change the build system so that all-inclusive app bundle builds become the default coupled to CMake's APPLE platform token? :)

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10415

To: sbragin, #okular, rjvbb
Cc: rjvbb, cullmann, aacid, kde-mac, ltoscano, #okular, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180211/ed8ccca6/attachment.html>