D10249: Option to exit after printing

[Dileep Sankhla]

dileepsankhla marked an inline comment as done.
dileepsankhla added a comment.


  @aacid I have talked about using std::exit instead of QCoreApplication::exit here : https://phabricator.kde.org/D10249#200260
  
  With that, I want to add QCoreApplication::exit does nothing if the event loop is not running. You can find the info in the docs here: http://doc.qt.io/qt-5/qcoreapplication.html#exit

INLINE COMMENTS

> aacid wrote in part.cpp:3212
> What is the value of isError when
> 
>   if ( printDialog->exec() )
> 
> returns false?

Undefined behavior - isError can either be true or false, my bad. Submitting a new patch.

> aacid wrote in part.cpp:3217
> We discussed a bit on IRC but i don't remeber which your reason for not using QCoreApplication::exit were, can you please remind me?

I have talked about using std::exit instead of QCoreApplication::exit here : https://phabricator.kde.org/D10249#200260

With that, I want to add that QCoreApplication::exit does nothing if the event loop is not running. You can find the info in the docs here: http://doc.qt.io/qt-5/qcoreapplication.html#exit

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10249

To: dileepsankhla, aacid, #okular, ngraham
Cc: ltoscano, ngraham, aacid, #okular, michaelweghorn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180211/7823c3b0/attachment.html>