D10049: [PATCH 3/4] Add initial support for built-in javascript functs

[Andre Heinecke]

aheinecke marked an inline comment as done.
aheinecke added inline comments.

INLINE COMMENTS

> aacid wrote in builtin.js:35
> why set ret to 1 if ret is 0? is this because you want to initialize? then you should test i is 0 otherwise 3*0*4 will be 4?

Indeed and nice catch :-). For PRD I wanted to set the start value to 1 and not 0. I made this more explicit now.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10049

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180208/84917ae7/attachment.html>