D10049: [PATCH 3/4] Add initial support for built-in javascript functs

Albert Astals Cid noreply at phabricator.kde.org
Sat Feb 3 19:59:20 UTC 2018


aacid added inline comments.

INLINE COMMENTS

> builtin.js:35
> +            {
> +                ret = 1;
> +            }

why set ret to 1 if ret is 0? is this because you want to initialize? then you should test i is 0 otherwise 3*0*4 will be 4?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10049

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180203/ef9d9973/attachment.html>


More information about the Okular-devel mailing list