D15123: Show tooltips when hovering over links regardless of which mouse tool is currently selected

Oliver Sander noreply at phabricator.kde.org
Tue Aug 28 14:20:37 BST 2018


sander created this revision.
sander added a reviewer: Okular.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
sander requested review of this revision.

REVISION SUMMARY
  Currently these tooltips only appear in 'Browse' mode.  KDE bug https://bugs.kde.org/show_bug.cgi?id=397783 asks for them to be shown in 'text selection' mode, too.  I don't really see a reason to disable them in any mode, and therefore this patch simply removes the check for the mouse mode completely.

TEST PLAN
  1 Open a pdf file with an internal or hyperlink
  2 Switch to Browse mode
  3 Hover over the link: a tooltip with the link target appears
  4 Switch to text selection, zoom, magnifier, or any other mouse mode
  5 Repeat Step 3: it still works

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15123

AFFECTED FILES
  ui/pageview.cpp

To: sander, #okular
Cc: okular-devel, ngraham, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20180828/fdcb2729/attachment.html>


More information about the Okular-devel mailing list